feat(todo): better handle (sub)tasks update; revamp styling#74
Merged
Conversation
tatomyr
changed the title
tatomyr
force-pushed
the
fix-task-update
branch
from
13feaa8 to
18564ae
Compare
tatomyr
changed the title
There was a problem hiding this comment.
Pull request overview
This PR enhances the todo application's task management functionality and implements a comprehensive styling revamp using CSS custom properties. The key improvements include automatic task completion based on subtasks status, better update tracking with silent updates, and a modernized theme system supporting both light and dark modes.
- Added logic to automatically complete/uncomplete tasks based on subtask states when closing task details
- Introduced a
silentUpdateparameter to prevent unnecessaryupdatedAttimestamp changes during UI-driven updates - Refactored styling to use CSS custom properties (variables) for comprehensive theming with enhanced dark mode support
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/purity.ts | Improved debug console messages for DOM updates |
| src/examples/purity-todo/services/tasks.ts | Added silentUpdate parameter to patchTask to control timestamp updates |
| src/examples/purity-todo/services/task-details.ts | Implemented automatic task completion logic based on subtasks status |
| src/examples/purity-todo/services/task-details.test.ts | Added comprehensive test coverage for new subtask completion behavior |
| src/examples/purity-todo/purity-todo.sw.ts | Version bump to 2.20 |
| src/examples/purity-todo/manifest.json | Version bump to 2.20 |
| src/examples/purity-todo/components/task-list-style.ts | Replaced hardcoded colors with CSS variables; removed stale task styling |
| src/examples/purity-todo/components/task-item.ts | Added unique ID to task description element |
| src/examples/purity-todo/components/task-item.test.ts | Updated snapshots to reflect new element ID |
| src/examples/purity-todo/components/task-details.ts | Removed trailing whitespace |
| src/examples/purity-todo/components/task-details-style.ts | Applied CSS variables; added text overflow handling |
| src/examples/purity-todo/components/subtask-item.ts | Refactored to extract subtask arrays before calling patchTask |
| src/examples/purity-todo/components/modal-style.ts | Converted hardcoded colors to CSS variables |
| src/examples/purity-todo/components/input-form.ts | Applied CSS variables and added focus outline styling |
| src/examples/purity-todo/components/header.ts | Restructured CSS with nested selectors and CSS variables |
| src/examples/purity-todo/components/app-style.ts | Introduced comprehensive CSS variable system for theming with enhanced light/dark mode support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.